-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISC Restructure - Small Fixes #1498
Conversation
Review note in intro about on and off ledger requests, add link to actual explanation double check ShimmerEVM Testnet nomenclature Move test smart contracts down, add examples add link to deploy in basic SC remove highlight ERC721 move EVM to top layer (AKA group by intent or topic, rather than VM) rotate full example where it's different tabs in create foundry tabs in mint native tokens review intructions in register-token review headers allowance add warning about ERC20 in getbalance add note about onledger requests on /isc/explanations/invocation/ move /isc/explanations/proxies/ to wasm add link to JSON RPC in isc/getting-started/compatibility/#wrapped-calls-to-the-json-rpc
This pull request has been deployed to Vercel. Latest commit: e729a17 ✅ Preview: https://iota-wiki-dfpp0ibdy-iota1.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the EVM change was not intended that way. @jlvandenhout thought more about a rename.
But in general I think we should rethink that section
docs/build/isc/v1.0.0-rc.6/docs/_admonitions/_off-ledger-requests.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/getting-started/compatibility.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dr-Electron <[email protected]>
I would restructure the sidebar/content like this: From:
To:
|
no ERC.. examples?
No Solidity ERC how tos? |
No. As we once said there are tutorials others did better. Our USP is the core contracts basically |
That's one way of looking at it. The other is that we should cover the basics. There's a middle ground which would be VM agnostic but cover Solidity as well. That being said, we can probably target that for another iteration and close this huge PR once and for all. |
Description of change
Links to any relevant issues
fixes iotaledger/devx#341
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.