Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Create Foundry' how-to #1461

Merged
merged 13 commits into from
Feb 20, 2024
Merged

Add 'Create Foundry' how-to #1461

merged 13 commits into from
Feb 20, 2024

Conversation

Dr-Electron
Copy link
Collaborator

@Dr-Electron Dr-Electron commented Feb 11, 2024

Description of change

Created a how to to create a L1 foundry on L2.

Links to any relevant issues

Fixes #1460.

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work

@Dr-Electron
Copy link
Collaborator Author

@Dr-Electron Dr-Electron linked an issue Feb 12, 2024 that may be closed by this pull request
@Dr-Electron Dr-Electron marked this pull request as ready for review February 16, 2024 14:03
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1d1cfdb

✅ Preview: https://iota-wiki-2rofcicsy-iota1.vercel.app

@Dr-Electron
Copy link
Collaborator Author

Btw I think I will change my how tos for tokens:
Instead of hardcoding the allowance assets I will make it payable and add a check > 0 for base tokens with a warning that says please fund storage deposit.
Later on the check should check for estimated storage deposit I guess.

Then I can add an admonition that you might want to work with allow or ownable functions depending on your use case wdyt?

@Dr-Electron
Copy link
Collaborator Author

Updated the docs and contract. Not sure what I think about the admonitions and their placement yet 😅

@Dr-Electron Dr-Electron merged commit e42e22c into ISC/restructure Feb 20, 2024
@Dr-Electron Dr-Electron deleted the createFoundry branch February 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Create foundry" how to
2 participants