-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace private tangle with Sandbox #1433
Conversation
We have to integrate the sandbox in our CI and local workflow first, before we can accept this PR |
The move to sandbox requires some changes to the examples and readmes (iotaledger/identity.rs#1290). I think we should merge these wiki changes with the next version of identity to keep it consistent. This would only make it consistent for the upcoming version (1.1) though. To also make it consistent with the current 1.0 version we would need a hotfix with the same changes. |
I don't think it'll be removed, we're just moving away from the term for the most part. We can probably leave it as is in 1.0 and use the sandbox as of 1.1. @Dr-Electron, any thoughts on this? |
That would be ideal. With the next version after that (v1.2) we would likely rotate out v1.0 and then it would become a non issue. |
Adopted changes for Identity v1.1 here |
There is a PR that renames the private tangle folder in hornet, but other then that currently no one cares about hornet so nothing will change in the near future 😆. So you should be fine continue using it |
Can you resolve the conflicts? |
Co-authored-by: Lucas Tortora <[email protected]>
1044ace
to
37fcb85
Compare
Description of change
Type of change
Change checklist