Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace private tangle with Sandbox #1433

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

  • replace private tangle with Sandbox

Type of change

  • Documentation Fix

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora lucas-tortora marked this pull request as ready for review February 1, 2024 13:36
@eike-hass
Copy link
Contributor

We have to integrate the sandbox in our CI and local workflow first, before we can accept this PR

@eike-hass
Copy link
Contributor

eike-hass commented Feb 2, 2024

The move to sandbox requires some changes to the examples and readmes (iotaledger/identity.rs#1290).

I think we should merge these wiki changes with the next version of identity to keep it consistent. This would only make it consistent for the upcoming version (1.1) though. To also make it consistent with the current 1.0 version we would need a hotfix with the same changes.
Will the private tangle be removed from hornet anytime soon? Otherwise we prefer to leave 1.0 as is and use sandbox from 1.1 onwards.

@lucas-tortora
Copy link
Collaborator Author

The move to sandbox requires some changes to the examples and readmes (iotaledger/identity.rs#1290).

I think we should merge these wiki changes with the next version of identity to keep it consistent. This would only make it consistent for the upcoming version (1.1) though. To also make it consistent with the current 1.0 version we would need a hotfix with the same changes. Will the private tangle be removed from hornet anytime soon? Otherwise we prefer to leave 1.0 as is and use sandbox from 1.1 onwards.

I don't think it'll be removed, we're just moving away from the term for the most part. We can probably leave it as is in 1.0 and use the sandbox as of 1.1. @Dr-Electron, any thoughts on this?

@eike-hass
Copy link
Contributor

eike-hass commented Feb 2, 2024

The move to sandbox requires some changes to the examples and readmes (iotaledger/identity.rs#1290).
I think we should merge these wiki changes with the next version of identity to keep it consistent. This would only make it consistent for the upcoming version (1.1) though. To also make it consistent with the current 1.0 version we would need a hotfix with the same changes. Will the private tangle be removed from hornet anytime soon? Otherwise we prefer to leave 1.0 as is and use sandbox from 1.1 onwards.

I don't think it'll be removed, we're just moving away from the term for the most part. We can probably leave it as is in 1.0 and use the sandbox as of 1.1. @Dr-Electron, any thoughts on this?

That would be ideal. With the next version after that (v1.2) we would likely rotate out v1.0 and then it would become a non issue.

@eike-hass
Copy link
Contributor

eike-hass commented Feb 2, 2024

Adopted changes for Identity v1.1 here
The changes for Identity v1.0 can be reverted here

@lucas-tortora lucas-tortora marked this pull request as ready for review February 2, 2024 13:36
@Dr-Electron
Copy link
Collaborator

There is a PR that renames the private tangle folder in hornet, but other then that currently no one cares about hornet so nothing will change in the near future 😆. So you should be fine continue using it

Base automatically changed from add-sandbox-docs to main February 2, 2024 21:59
@Dr-Electron
Copy link
Collaborator

Can you resolve the conflicts?

@lucas-tortora lucas-tortora force-pushed the recommend-sandbox-instead-of-alternatives branch from 1044ace to 37fcb85 Compare February 5, 2024 14:32
@Dr-Electron Dr-Electron merged commit 956d97e into main Feb 7, 2024
11 checks passed
@Dr-Electron Dr-Electron deleted the recommend-sandbox-instead-of-alternatives branch February 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants