Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically pull chain id #1360

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Automatically pull chain id #1360

merged 4 commits into from
Dec 2, 2023

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

I added a component to automatically pull the chain ID. This is mainly useful for the testnet chain.

Links to any relevant issues

Fixes #1306.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

jlvandenhout
jlvandenhout previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jlvandenhout jlvandenhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one suggestion. Also, just nitpicking, maybe just call it ChainId, because that's what it renders. Either way, is fine for me 👍

theme/src/theme/GetChainId/index.tsx Outdated Show resolved Hide resolved
jlvandenhout
jlvandenhout previously approved these changes Dec 2, 2023
View reviewed changes
@Dr-Electron Dr-Electron merged commit 074b056 into main Dec 2, 2023
11 checks passed
@Dr-Electron Dr-Electron deleted the get-chainid branch December 2, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlvandenhout jlvandenhout jlvandenhout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically pull chain id
2 participants
@Dr-Electron @jlvandenhout