Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shimmer-firefly-governance-guide.md #1261

Merged
merged 9 commits into from
Oct 22, 2023
Merged

Conversation

Phyloiota
Copy link
Collaborator

@Phyloiota Phyloiota commented Oct 19, 2023

Grammar, spelling and Make the guide generic for IOTA and Shimmer

Description of change

Made the guide generic to both Firefly versions

Links to any relevant issues

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

Grammar, spelling and Make the guide generic for IOTA and Shimmer
rename, remove Shimmer
@Phyloiota Phyloiota requested a review from Dr-Electron October 19, 2023 23:57
@Phyloiota Phyloiota marked this pull request as ready for review October 19, 2023 23:57
@Phyloiota Phyloiota requested a review from Dr-Electron October 20, 2023 14:47
Dr-Electron
Dr-Electron previously approved these changes Oct 22, 2023
Dr-Electron
Dr-Electron previously approved these changes Oct 22, 2023
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some broken links and now it looks good to me.
Keep in mind that now some links on the wiki will be changed with all those changes.

Also you might want to change the image (shimmer-gov.png)

@Phyloiota
Copy link
Collaborator Author

updated the images as suggested

@Phyloiota Phyloiota requested a review from Dr-Electron October 22, 2023 22:54
@Dr-Electron Dr-Electron merged commit f7858f7 into main Oct 22, 2023
11 checks passed
@Dr-Electron Dr-Electron deleted the Phyloiota-patch-1 branch October 22, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants