Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validators Article #1260

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Add Validators Article #1260

merged 7 commits into from
Oct 19, 2023

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

Added validators article and images

Links to any relevant issues

part of iotaledger/devx#215

Type of change

  • Documentation

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora @polinikita
Apply suggestions from code review
04c68e9 
Co-authored-by: Nikita Polianskii <[email protected]>
polinikita
polinikita suggested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@polinikita polinikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether the provided links will work correctly.

@lucas-tortora
Copy link
Collaborator Author

Please check whether the provided links will work correctly.

They do. The build action should catch any dead links :)

polinikita
polinikita reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@polinikita polinikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things to change

@Dr-Electron
Copy link
Collaborator

Preview: https://iota-wiki-1c5kcx7um-iota1.vercel.app/

@lucas-tortora lucas-tortora merged commit 0fbbfde into main Oct 19, 2023
12 checks passed
@Dr-Electron Dr-Electron deleted the addValidatorsArticle branch October 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcy-camargo darcy-camargo Awaiting requested review from darcy-camargo

@DafPhil DafPhil Awaiting requested review from DafPhil

@polinikita polinikita Awaiting requested review from polinikita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucas-tortora @Dr-Electron @polinikita