Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consensus articles #1251

Merged
merged 18 commits into from
Oct 17, 2023
Merged

Add consensus articles #1251

merged 18 commits into from
Oct 17, 2023

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

Added consensus articles
Added links in data flor and data structures

Links to any relevant issues

iotaledger/devx#215

Type of change

  • Documentation

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora
Copy link
Collaborator Author

Preview: https://iota-wiki-p5tafqjtd-iota1.vercel.app/learn/protocols/iota2.0/core-concepts/consensus/introduction/

@lucas-tortora
Copy link
Collaborator Author

Updated preview : https://iota-wiki-b4d1fgrso-iota1.vercel.app/learn/protocols/iota2.0/core-concepts/consensus/introduction/

polinikita
polinikita reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@polinikita polinikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would remove <code.> appearance around formulas which was introduced instead of backticks in the original file. Backticks inside formulas served a different purpose in github md files, so the code environment is not needed.
  2. Some small corrections are provided
  3. I suggest to disable the old glossary for this wiki page. Otherwise, it is very confusing

@lucas-tortora lucas-tortora marked this pull request as ready for review October 17, 2023 14:35
@lucas-tortora lucas-tortora merged commit cca5661 into main Oct 17, 2023
11 of 12 checks passed
@Dr-Electron Dr-Electron deleted the addConsensusArticle branch October 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polinikita polinikita polinikita approved these changes

@darcy-camargo darcy-camargo Awaiting requested review from darcy-camargo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-tortora @polinikita