Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference script #1248

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update reference script #1248

merged 1 commit into from
Oct 23, 2023

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

I changed the sdk references script to just download the references as we are now creating them in the SDK

Links to any relevant issues

Fixes #1183.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron marked this pull request as ready for review October 13, 2023 22:36
@Dr-Electron
Copy link
Collaborator Author

I will wait with this until iotaledger/iota-sdk#1412 gets merged. Just to be sure they don't want anything changed (I don't think so, but you never know)

Copy link
Contributor

@jlvandenhout jlvandenhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this!

@lucas-tortora
Copy link
Collaborator

@Dr-Electron
Copy link
Collaborator Author

PR in the SDK got merged. Let's gooo ;)

@Dr-Electron Dr-Electron merged commit c27e832 into main Oct 23, 2023
@Dr-Electron Dr-Electron deleted the update-reference-script branch October 23, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to pull auto generated docs from server
3 participants