Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias outputs doc #1153

Merged
merged 23 commits into from
Sep 26, 2023
Merged

Alias outputs doc #1153

merged 23 commits into from
Sep 26, 2023

Conversation

anistark
Copy link
Contributor

@anistark anistark commented Sep 4, 2023

Description of change

Added alias create, destroy docs.

Links to any relevant issues

fixes issue #1111

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work

@anistark anistark requested a review from Dr-Electron September 4, 2023 10:22
@luca-moser luca-moser linked an issue Sep 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two broken links

docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
@Dr-Electron
Copy link
Collaborator

/create-preview

@Dr-Electron
Copy link
Collaborator

Btw those examples are not aligned and don't create the same output. You should make sure the same useful output is created in the example. You can compare for example how we did it in the native token examples

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-2fow0xyrq-iota1.vercel.app

@Dr-Electron
Copy link
Collaborator

Also you don't import the correct lines of code 😅

docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/create.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
docs/build/iota-sdk/1.0.0/docs/how-tos/alias/destroy.mdx Outdated Show resolved Hide resolved
@Dr-Electron
Copy link
Collaborator

Btw those examples are not aligned and don't create the same output. You should make sure the same useful output is created in the example. You can compare for example how we did it in the native token examples

Are you going to work on it, or do you want to create another PR afterwards?

@anistark
Copy link
Contributor Author

Btw those examples are not aligned and don't create the same output. You should make sure the same useful output is created in the example. You can compare for example how we did it in the native token examples

Are you going to work on it, or do you want to create another PR afterwards?

Python output is left to match. Will open a PR to sdk and then come back to this. Let it stay open till then?

@anistark
Copy link
Contributor Author

anistark commented Sep 12, 2023

The examples don't run on my system as usual. So, not able to test it out. nodejs and rust outputs are same now.
Here's my PR. If you're free, please check out python code.

@Dr-Electron
Copy link
Collaborator

The examples don't run on my system as usual. So, not able to test it out. nodejs and rust outputs are same now.
Here's my PR. If you're free, please check out python code.

Unrelated question, but:
Did you create an issue to track this btw? I forgot if you did 😅

@Dr-Electron
Copy link
Collaborator

Can you please resolve the conflict. Let's get this merged 🦾

luca-moser
luca-moser previously approved these changes Sep 25, 2023
luca-moser
luca-moser previously approved these changes Sep 26, 2023
@luca-moser luca-moser merged commit 56d32ef into main Sep 26, 2023
11 checks passed
@luca-moser luca-moser deleted the alias-output-doc branch September 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs on iota-sdk alias output create, destroy example
4 participants