Refactor block signature #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thoralf-M <[email protected]>
Thoralf-M
reviewed
Oct 4, 2023
thibault-martinez
requested changes
Oct 4, 2023
added 2 commits
October 4, 2023 14:59
thibault-martinez
previously approved these changes
Oct 4, 2023
Thoralf-M
previously approved these changes
Oct 4, 2023
Alex6323
previously approved these changes
Oct 5, 2023
thibault-martinez
dismissed stale reviews from Thoralf-M, Alex6323, and themself
via
64c4550
Thoralf-M
approved these changes
Oct 5, 2023
Alex6323
approved these changes
Oct 5, 2023
thibault-martinez
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
After reading through the TIPs, I made some changes to how the block builder works to allow for calculating the block signature from the header and data hashes. I added a trait to allow random signing for tests, and likely a similar trait could simplify the UX for the block builder as well.
Links to any relevant issues