-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable modifying Block Issuer Keys in CLI Wallet #2235
Merged
thibault-martinez
merged 12 commits into
iotaledger:2.0
from
PhilippGackstatter:feat/cli-wallet-block-issuer-keys
Apr 29, 2024
Merged
Enable modifying Block Issuer Keys in CLI Wallet #2235
thibault-martinez
merged 12 commits into
iotaledger:2.0
from
PhilippGackstatter:feat/cli-wallet-block-issuer-keys
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
sdk/src/wallet/operations/transaction/high_level/account_block_issuer_keys.rs
Outdated
Show resolved
Hide resolved
sdk/src/wallet/operations/transaction/high_level/account_block_issuer_keys.rs
Outdated
Show resolved
Hide resolved
sdk/src/wallet/operations/transaction/high_level/account_block_issuer_keys.rs
Outdated
Show resolved
Hide resolved
1 task
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Thoralf-M
reviewed
Apr 29, 2024
sdk/src/wallet/operations/transaction/high_level/account_block_issuer_keys.rs
Outdated
Show resolved
Hide resolved
…_issuer_keys.rs Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Thoralf-M
previously approved these changes
Apr 29, 2024
… into feat/cli-wallet-block-issuer-keys
thibault-martinez
previously approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reopened a comment just to be sure, resolve again if you want
Thoralf-M
approved these changes
Apr 29, 2024
thibault-martinez
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Enable modifying Block Issuer Keys in CLI Wallet. This is so prospect validators can easily add a second dedicated block issuer key for use in
inx-validator
. It needs the private key corresponding to the block issuer key in order to be able to issue validation blocks. Since the private key of the block issuer key added by the sdk is in stronghold or the ledger and thus not extractable, a new command was necessary to be able to add external block issuer keys.Links to any relevant issues
n/a
Type of change
How the change has been tested
Manual local testing with the cli.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.