Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output storage score tests #1827

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Add output storage score tests #1827

merged 11 commits into from
Jan 17, 2024

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Jan 10, 2024

Description of change

Adds tests from the output TIPs as fixtures.

Links to any relevant issues

Closes #1233
BLOCKED BY #1764

@DaughterOfMars DaughterOfMars linked an issue Jan 10, 2024 that may be closed by this pull request
Alex6323
Alex6323 previously approved these changes Jan 10, 2024
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- TRY 3 STDERR:        iota-sdk::mod types::storage_score::output_storage_score ---
thread 'types::storage_score::output_storage_score' panicked at sdk\tests\types\storage_score.rs:38:51:
called `Result::unwrap()` on an `Err` value: Error("data did not match any variant of untagged enum Output", line: 0, column: 0)

@thibault-martinez
Copy link
Member

--- TRY 3 STDERR:        iota-sdk::mod types::storage_score::output_storage_score ---
thread 'types::storage_score::output_storage_score' panicked at sdk\tests\types\storage_score.rs:38:51:
called `Result::unwrap()` on an `Err` value: Error("data did not match any variant of untagged enum Output", line: 0, column: 0)

That's because we need to merge the MetadataFeature PR first

Thoralf-M
Thoralf-M previously approved these changes Jan 17, 2024
@Thoralf-M Thoralf-M merged commit cb0d39f into 2.0 Jan 17, 2024
36 checks passed
@Thoralf-M Thoralf-M deleted the feat/output-storage-tests branch January 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable rent-cost test
4 participants