Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align method serialization in Python #1824

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Align method serialization in Python #1824

merged 11 commits into from
Jan 12, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Align method serialization in Python
Fix TimelockUnlockConditionDto

Links to any relevant issues

Closes #650

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running examples

DaughterOfMars
DaughterOfMars previously approved these changes Jan 10, 2024
View reviewed changes
Copy link

@DaughterOfMars DaughterOfMars left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend to understand all of the python nonsense, but looks ok to me

thibault-martinez
thibault-martinez requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing

@Thoralf-M Thoralf-M linked an issue Jan 11, 2024 that may be closed by this pull request
Align Python serialization #650
Closed
@thibault-martinez thibault-martinez merged commit 9c8956a into iotaledger:2.0 Jan 12, 2024
36 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Jan 12, 2024
Closed
@Thoralf-M Thoralf-M deleted the python-serialization branch January 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@Alex6323 Alex6323 Alex6323 approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align Python serialization
4 participants
@Thoralf-M @thibault-martinez @DaughterOfMars @Alex6323