CLI: better UX for accounts and implicit_accounts commands #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
approved these changes
Jan 9, 2024
Alex6323
reviewed
Jan 9, 2024
Comment on lines
+322
to
+333
| for account in accounts { | ||
| let output_id = account.output_id; | ||
| let account_id = account.output.as_account().account_id_non_null(&output_id); | ||
| let account_address = account_id.to_bech32(wallet.client().get_bech32_hrp().await?); | ||
|
|
||
| println_log_info!( | ||
| "{:<16} {output_id}\n{:<16} {account_id}\n{:<16} {account_address}\n", | ||
| "Output ID:", | ||
| "Account ID:", | ||
| "Account Address:" | ||
| ); | ||
| } |
There was a problem hiding this comment.
can this be factored out into a function bc you do the same for the implicit accounts, right?
There was a problem hiding this comment.
It's not the same
kwek20
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.