Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MetadataFeature #1764

Merged
merged 68 commits into from
Jan 17, 2024
Merged

Update MetadataFeature #1764

merged 68 commits into from
Jan 17, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Refactor MetadataFeature to be compatible with https://github.com/iotaledger/tips/blob/tip38/tips/TIP-0038/tip-0038.md#metadata-feature

Links to any relevant issues

Closes #1693

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running tests

@Thoralf-M Thoralf-M force-pushed the refactor-MetadataFeature branch 3 times, most recently from c0e65dc to 5d92ece Compare December 12, 2023 09:44
@Thoralf-M Thoralf-M marked this pull request as ready for review December 12, 2023 09:44
@Thoralf-M
Copy link
Member Author

Please review only sdk/src/types/block/output/feature/metadata.rs for now

@Alex6323
Copy link
Contributor

Please review only sdk/src/types/block/output/feature/metadata.rs for now

Why not keep it a draft then? 🤔 (You know we can also review that file if it's a draft :trollface: )

@thibault-martinez
Copy link
Member

Please review only sdk/src/types/block/output/feature/metadata.rs for now

Looks overall fine to me

Alex6323
Alex6323 previously approved these changes Jan 9, 2024
View reviewed changes
@Thoralf-M Thoralf-M force-pushed the refactor-MetadataFeature branch from 8daaf54 to 772f019 Compare January 9, 2024 14:40
@Alex6323 Alex6323 mentioned this pull request Jan 17, 2024
Merged
@thibault-martinez thibault-martinez merged commit b809589 into iotaledger:2.0 Jan 17, 2024
36 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Jan 17, 2024
Closed
@Thoralf-M Thoralf-M deleted the refactor-MetadataFeature branch January 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwek20 kwek20 kwek20 left review comments

@Alex6323 Alex6323 Alex6323 approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor MetadataFeature
5 participants
@Thoralf-M @Alex6323 @thibault-martinez @kwek20 @DaughterOfMars