Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename block types #1626

Merged
merged 13 commits into from
Nov 17, 2023
Merged

Rename block types #1626

merged 13 commits into from
Nov 17, 2023

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Nov 15, 2023 •
edited
Loading

Links to any relevant issues

Closes #1515

@Alex6323 Alex6323 linked an issue Nov 16, 2023 that may be closed by this pull request
Rename block types? #1515
Closed
@Alex6323 Alex6323 marked this pull request as ready for review November 16, 2023 09:01
thibault-martinez
thibault-martinez requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still Response::SignedBlock in the bindings core.
Actually do a search for SignedBlock because there is more remaining.

thibault-martinez
thibault-martinez requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some in bindings/core/tests/combined.rs and sdk/tests/types/block_id.rs. Commented but let's remove anyway.

@Alex6323
Copy link
Contributor Author

Alex6323 commented Nov 16, 2023 •
edited
Loading

Conflicts ... Alex ... Conflicts -> ☕

@Alex6323
Copy link
Contributor Author

Still some in bindings/core/tests/combined.rs and sdk/tests/types/block_id.rs. Commented but let's remove anyway.

fixed I guess unless I overlooked something.

kwek20
kwek20 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yepyep lgtm! nice self changes too :)

@thibault-martinez thibault-martinez merged commit 066cbd6 into iotaledger:2.0 Nov 17, 2023
26 of 35 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Nov 17, 2023
Closed
@Alex6323 Alex6323 deleted the rename-block-types branch November 17, 2023 16:36
@Thoralf-M Thoralf-M mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename block types?
4 participants
@Alex6323 @kwek20 @thibault-martinez @Thoralf-M