Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit account transition #1598

Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
78bdad3
First draft
thibault-martinez Nov 8, 2023
2be5e03
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 20, 2023
e6e6bbc
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 21, 2023
8b5c2d1
Wallet implicit_account_transition method
thibault-martinez Nov 21, 2023
f0ed640
Add to CLI
thibault-martinez Nov 21, 2023
83d7e1d
Support for ImplicitAccountCreation in ISA filter
thibault-martinez Nov 21, 2023
5705c38
Support for ImplicitAccountCreation in ISA required_account_nft_addre…
thibault-martinez Nov 21, 2023
565fdd6
Support for implicit accounts in ISA is_account_with_id
thibault-martinez Nov 21, 2023
ace5d05
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 21, 2023
1888c18
Support implicit accounts in ISA validate_transitions
thibault-martinez Nov 21, 2023
ed565bf
Fix default_transaction_unlocks
thibault-martinez Nov 21, 2023
e450a2e
Add implicit accounts to input chains
thibault-martinez Nov 21, 2023
50554a6
Allow implicit accounts in verify_state_transition
thibault-martinez Nov 21, 2023
ce09c83
Tmp null IssuerId
thibault-martinez Nov 21, 2023
6052807
Set public key
thibault-martinez Nov 21, 2023
a34f981
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 22, 2023
8146d5e
Add TODOs
thibault-martinez Nov 22, 2023
2966963
Add to bindings core
thibault-martinez Nov 22, 2023
59844cd
Nodejs bindings
thibault-martinez Nov 22, 2023
fce4e5b
fix
thibault-martinez Nov 22, 2023
f664acb
Python bindings
thibault-martinez Nov 22, 2023
39a23ee
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 22, 2023
02d953d
TODO and errors
thibault-martinez Nov 22, 2023
f154e1d
Use u32::MAX
thibault-martinez Nov 22, 2023
d952349
Fix address
thibault-martinez Nov 22, 2023
726c7e5
Remove account file
thibault-martinez Nov 22, 2023
03e662c
Add prepare versions
thibault-martinez Nov 22, 2023
d651596
Add Restricted in match
thibault-martinez Nov 22, 2023
333204f
Update bindings/python/iota_sdk/wallet/account.py
thibault-martinez Nov 22, 2023
a2adb75
Log CLI transaction
thibault-martinez Nov 22, 2023
a77dfa5
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 23, 2023
bd38620
unreachable -> panic
thibault-martinez Nov 23, 2023
23cc71e
Merge branch '2.0' into implicit-account-creation-transition
thibault-martinez Nov 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindings/core/src/method/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ pub enum WalletMethod {
/// Returns the implicit account creation address of the wallet if it is Ed25519 based.
/// Expected response: [`Bech32Address`](crate::Response::Bech32Address)
ImplicitAccountCreationAddress,
/// Prepares to transition an implicit account to an account.
/// Expected response: [`PreparedTransaction`](crate::Response::PreparedTransaction)
#[serde(rename_all = "camelCase")]
PrepareImplicitAccountTransition { output_id: OutputId },
/// Returns the implicit accounts of the wallet.
/// Expected response: [`OutputsData`](crate::Response::OutputsData)
ImplicitAccounts,
Expand Down
4 changes: 4 additions & 0 deletions bindings/core/src/method_handler/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,10 @@ pub(crate) async fn call_wallet_method_internal(wallet: &Wallet, method: WalletM
let implicit_account_creation_address = wallet.implicit_account_creation_address().await?;
Response::Bech32Address(implicit_account_creation_address)
}
WalletMethod::PrepareImplicitAccountTransition { output_id } => {
let data = wallet.prepare_implicit_account_transition(&output_id).await?;
Response::PreparedTransaction(PreparedTransactionDataDto::from(&data))
}
WalletMethod::ImplicitAccounts => {
let implicit_accounts = wallet.implicit_accounts().await;
Response::OutputsData(implicit_accounts.iter().map(OutputDataDto::from).collect())
Expand Down
1 change: 1 addition & 0 deletions bindings/core/src/response.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ pub enum Response {
/// - [`PrepareStopParticipating`](crate::method::WalletMethod::PrepareStopParticipating)
/// - [`PrepareTransaction`](crate::method::WalletMethod::PrepareTransaction)
/// - [`PrepareVote`](crate::method::WalletMethod::PrepareVote)
/// - [`PrepareImplicitAccountTransition`](crate::method::WalletMethod::PrepareImplicitAccountTransition)
PreparedTransaction(PreparedTransactionDataDto),
/// Response for:
/// - [`PrepareCreateNativeToken`](crate::method::WalletMethod::PrepareCreateNativeToken),
Expand Down
Loading
Loading