Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic validation optional unlocks #1572

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Semantic validation optional unlocks #1572

merged 14 commits into from
Nov 30, 2023

Conversation

thibault-martinez
Copy link
Member

Closes #1570

@thibault-martinez thibault-martinez linked an issue Nov 29, 2023 that may be closed by this pull request
Have semantic_validation() for tx essence/payload without unlocks #1570
Closed
@thibault-martinez thibault-martinez marked this pull request as ready for review November 29, 2023 13:43
Thoralf-M
Thoralf-M previously approved these changes Nov 29, 2023
View reviewed changes
kwek20
kwek20 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we return Response::ok instead of TransactionFailureReason(None) ?

@thibault-martinez thibault-martinez mentioned this pull request Nov 30, 2023
Closed
4 tasks
@thibault-martinez
Copy link
Member Author

cant we return Response::ok instead of TransactionFailureReason(None) ?

I have added your comment in #1565 because this is linked. Let's keep as is for now.

@thibault-martinez thibault-martinez merged commit d58d964 into iotaledger:2.0 Nov 30, 2023
29 of 36 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Nov 30, 2023
Closed
@thibault-martinez thibault-martinez deleted the semantic-optional-unlocks branch January 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have semantic_validation() for tx essence/payload without unlocks
5 participants
@thibault-martinez @kwek20 @DaughterOfMars @Alex6323 @Thoralf-M