Fail tests early when "storage" not enabled #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2023 13:52
Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
This allows us to fail early if the storage feature is not enabled, rather than having code which appears to work but doesn't. Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
Thoralf-M
reviewed
Nov 3, 2023
Thoralf-M
approved these changes
Nov 22, 2023
thibault-martinez
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The tests currently fail in confusing ways, due to "storage" not being enabled by default in bindings. Curiously, it does seem to be enabled in the wallet (running this code, and causing test failures when ran concurrently), breaking the functionality of each test using a custom, unique storage location.
This makes the test fail early (in compile time) if storage is not enabled, which makes sense given how heavily they rely on it. README now also documents how the tests should be run (we cannot force it, apparently).
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
cargo testnow passes in rootdir when "storage" is enabledChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.