Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework basic output unlock conditions + features #1471

Closed
wants to merge 1 commit into from

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Oct 19, 2023

Description of change

This PR is a test to see if it's feasible to use static typing for unlock conditions and features instead of arrays of enums. So far I have only changed the BasicOutput.

Downsides

  1. In order to get a UnlockConditions or Features from an output, you must now clone. This is usually not necessary since you can just use the specific getter most of the time, but it's useful for certain things.
  2. There is a lot of repeated code in Unpack/TryFromDto/try_from_dtos that really should be shared somehow. Unfortunately, this is not very straightforward.

@DaughterOfMars DaughterOfMars deleted the feat/rework-output-arrays branch October 20, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant