Rework basic output unlock conditions + features #1471
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is a test to see if it's feasible to use static typing for unlock conditions and features instead of arrays of enums. So far I have only changed the
BasicOutput
.Downsides
UnlockConditions
orFeatures
from an output, you must now clone. This is usually not necessary since you can just use the specific getter most of the time, but it's useful for certain things.