-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delegation to balance #1456
Merged
thibault-martinez
merged 8 commits into
iotaledger:2.0
from
Alex6323:feat/types/delegation-in-balance
Nov 27, 2023
Merged
Add delegation to balance #1456
thibault-martinez
merged 8 commits into
iotaledger:2.0
from
Alex6323:feat/types/delegation-in-balance
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
feat(types): Add delegation to balance
Add delegation to balance
Oct 19, 2023
thibault-martinez
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to actually use it when computing balances
Any news on this? |
Thoralf-M
previously approved these changes
Nov 7, 2023
DaughterOfMars
previously approved these changes
Nov 7, 2023
thibault-martinez
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd update the bindings as well since the change is super small
Thoralf-M
dismissed stale reviews from DaughterOfMars and themself
via
November 27, 2023 08:52
1be3a57
Thoralf-M
force-pushed
the
feat/types/delegation-in-balance
branch
from
November 27, 2023 08:52
0acdf28
to
1be3a57
Compare
Thoralf-M
previously approved these changes
Nov 27, 2023
DaughterOfMars
previously approved these changes
Nov 27, 2023
thibault-martinez
dismissed stale reviews from Thoralf-M and DaughterOfMars
via
November 27, 2023 16:00
9a535b9
DaughterOfMars
previously approved these changes
Nov 27, 2023
thibault-martinez
previously approved these changes
Nov 27, 2023
Thoralf-M
reviewed
Nov 27, 2023
Thoralf-M
dismissed stale reviews from thibault-martinez and DaughterOfMars
via
November 27, 2023 16:12
c8fa896
thibault-martinez
approved these changes
Nov 27, 2023
Thoralf-M
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to any relevant issues
Closes #1245