Allow QueryParameter::UnlockableByAddress for more routes

[Thoralf-M]

Description of change

Added QueryParameter::UnlockableByAddress to allowed query paramaters for Client::{alias_output_ids(), basic_output_ids(), nft_output_ids()} since this is now allowed by the indexer iotaledger/tips@0dd6217

Also changed the syncing in the wallet to make use of it

Links to any relevant issues

Fixes #1269

Type of change

• Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running an example with

    let output_ids_response = client
        .alias_output_ids([QueryParameter::UnlockableByAddress(address)])
        .await?;

and also synced a wallet with

SyncOptions {
            nft: NftSyncOptions {
                basic_outputs: true,
                ..Default::default()
            },
            ..Default::default()
        }

[thibault-martinez]

Is there nowhere we can actually use it already?

[Thoralf-M]

Is there nowhere we can actually use it already?

There is, should I include it in this PR? It's for example merging all this

iota-sdk/sdk/src/wallet/account/operations/syncing/addresses/output_ids/nft.rs

Lines 29 to 101 in b3f77d5

	{
	let mut output_ids = Vec::new();
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::Address(bech32_address)])
	.await?
	.items,
	);
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::StorageDepositReturnAddress(bech32_address)])
	.await?
	.items,
	);
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::ExpirationReturnAddress(bech32_address)])
	.await?
	.items,
	);
	Ok(output_ids)
	}
	#[cfg(not(target_family = "wasm"))]
	{
	let client = self.client();
	let tasks = [
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get nft outputs where the address is in the address unlock condition
	client
	.nft_output_ids([QueryParameter::Address(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get outputs where the address is in the storage deposit return unlock condition
	client
	.nft_output_ids([QueryParameter::StorageDepositReturnAddress(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get outputs where the address is in the expiration unlock condition
	client
	.nft_output_ids([QueryParameter::ExpirationReturnAddress(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	];
	// Get all results
	let mut output_ids = HashSet::new();
	let results: Vec<crate::wallet::Result<OutputIdsResponse>> = futures::future::try_join_all(tasks).await?;
	for res in results {
	let found_output_ids = res?;
	output_ids.extend(found_output_ids.items);
	}

[thibault-martinez]

Is there nowhere we can actually use it already?

There is, should I include it in this PR? It's for example merging all this

iota-sdk/sdk/src/wallet/account/operations/syncing/addresses/output_ids/nft.rs

Lines 29 to 101 in b3f77d5

	{
	let mut output_ids = Vec::new();
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::Address(bech32_address)])
	.await?
	.items,
	);
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::StorageDepositReturnAddress(bech32_address)])
	.await?
	.items,
	);
	output_ids.extend(
	self.client()
	.nft_output_ids([QueryParameter::ExpirationReturnAddress(bech32_address)])
	.await?
	.items,
	);
	Ok(output_ids)
	}
	#[cfg(not(target_family = "wasm"))]
	{
	let client = self.client();
	let tasks = [
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get nft outputs where the address is in the address unlock condition
	client
	.nft_output_ids([QueryParameter::Address(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get outputs where the address is in the storage deposit return unlock condition
	client
	.nft_output_ids([QueryParameter::StorageDepositReturnAddress(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	async move {
	let client = client.clone();
	tokio::spawn(async move {
	// Get outputs where the address is in the expiration unlock condition
	client
	.nft_output_ids([QueryParameter::ExpirationReturnAddress(bech32_address)])
	.await
	.map_err(From::from)
	})
	.await
	}
	.boxed(),
	];
	// Get all results
	let mut output_ids = HashSet::new();
	let results: Vec<crate::wallet::Result<OutputIdsResponse>> = futures::future::try_join_all(tasks).await?;
	for res in results {
	let found_output_ids = res?;
	output_ids.extend(found_output_ids.items);
	}

As you want, either in this PR or open an issue for later

[kwek20]

lovely code cleanup 👌

[DaughterOfMars]

🙏

[thibault-martinez]

Very nice