feat/python: unlock slotindex #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
previously approved these changes
Oct 4, 2023
DaughterOfMars
previously approved these changes
Oct 4, 2023
Alex6323
previously approved these changes
Oct 4, 2023
DaughterOfMars
previously approved these changes
Oct 4, 2023
DaughterOfMars
previously approved these changes
Oct 5, 2023
Thoralf-M
previously approved these changes
Oct 5, 2023
Co-authored-by: DaughterOfMars <[email protected]>
Alex6323
reviewed
Oct 6, 2023
Comment on lines
159
to
160
| * Defines a slot index until which only Address, defined in Address Unlock Condition, is allowed to unlock the output. | ||
| * After the slot index is reached/passed, only Return Address can unlock it. |
There was a problem hiding this comment.
Suggested change
| * Defines a slot index until which only Address, defined in Address Unlock Condition, is allowed to unlock the output. | |
| * After the slot index is reached/passed, only Return Address can unlock it. | |
| * Defines an unlock condition that binds an expiry time/slot index to the address given in the Address Unlock | |
| * Condition of the same output. Once that address has expired, only the address defined in `returnAddress` can | |
| * unlock the output. |
|
The issue was fixed by another PR, is this still relevant? |
Thoralf-M
previously approved these changes
Oct 10, 2023
Yes some things weren't changed |
Co-authored-by: DaughterOfMars <[email protected]>
Co-authored-by: DaughterOfMars <[email protected]>
DaughterOfMars
approved these changes
Oct 10, 2023
Thoralf-M
approved these changes
Oct 10, 2023
thibault-martinez
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fixes #963