Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Nodejs env var checks examples #1386

Merged
merged 8 commits into from
Oct 5, 2023
Merged

cleanup Nodejs env var checks examples #1386

merged 8 commits into from
Oct 5, 2023

Conversation

shreykul
Copy link
Contributor

@shreykul shreykul commented Oct 3, 2023

Description of change

Added a list of env for iteration as done in the python cleanup

Links to any relevant issues

fixes #1359

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Ran unit tests locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez
Copy link
Member

Hello, thanks for your PR!
Please do the changes to the develop branch, 1.1 has been released already and the branch will be removed soon.

@shreykul shreykul changed the base branch from 1.1 to develop October 3, 2023 16:39
@shreykul
Copy link
Contributor Author

shreykul commented Oct 5, 2023

Sorry it is just so confusing, i changed the files locally but weren't able to see the changes here so yeah that's why it took so much time in an easy thing...

@Thoralf-M
Copy link
Member

No worries, thanks for your PR!

@Thoralf-M Thoralf-M merged commit b3f77d5 into iotaledger:develop Oct 5, 2023
8 checks passed
@shreykul shreykul deleted the nodecleanenv branch October 5, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Nodejs env var checks in examples
4 participants