-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup Nodejs env var checks examples #1386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, thanks for your PR! |
Thoralf-M
reviewed
Oct 3, 2023
Thoralf-M
reviewed
Oct 4, 2023
Thoralf-M
reviewed
Oct 4, 2023
Thoralf-M
reviewed
Oct 4, 2023
Co-authored-by: Thoralf-M <[email protected]>
Co-authored-by: Thoralf-M <[email protected]>
Sorry it is just so confusing, i changed the files locally but weren't able to see the changes here so yeah that's why it took so much time in an easy thing... |
Thoralf-M
reviewed
Oct 5, 2023
bindings/nodejs/examples/how_tos/sign_secp256k1_ecdsa/sign-secp256k1_ecdsa.ts
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Oct 5, 2023
bindings/nodejs/examples/how_tos/sign_and_verify_ed25519/sign-ed25519.ts
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Oct 5, 2023
Thoralf-M
reviewed
Oct 5, 2023
Thoralf-M
reviewed
Oct 5, 2023
bindings/nodejs/examples/how_tos/accounts_and_addresses/create-address.ts
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Oct 5, 2023
bindings/nodejs/examples/how_tos/accounts_and_addresses/consolidate-outputs.ts
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Oct 5, 2023
No worries, thanks for your PR! |
Thoralf-M
approved these changes
Oct 5, 2023
Alex6323
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a list of env for iteration as done in the python cleanup
Links to any relevant issues
fixes #1359
Type of change
How the change has been tested
Ran unit tests locally.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.