Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction capabilities #1377

Merged
merged 31 commits into from
Oct 18, 2023
Merged

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Oct 2, 2023

Description of change

Adds the capabilities bit flags for transactions.

Open Questions

  • I cannot tell from the go code if the bit masks are correct.
  • How should we handle the 3 flags that do nothing?

Links to any relevant issues

Closes #1365
Blocked by iotaledger/iota-core#428

@thibault-martinez
Copy link
Member

This should also handle semantic validation.

@DaughterOfMars DaughterOfMars linked an issue Oct 3, 2023 that may be closed by this pull request
@DaughterOfMars DaughterOfMars marked this pull request as draft October 4, 2023 16:59
@thibault-martinez
Copy link
Member

Can be changed now that address caps have been merged ?

@DaughterOfMars DaughterOfMars marked this pull request as ready for review October 11, 2023 14:11
DaughterOfMars and others added 2 commits October 13, 2023 10:12
Thoralf-M
Thoralf-M previously approved these changes Oct 13, 2023
kwek20
kwek20 previously approved these changes Oct 17, 2023
Alex6323
Alex6323 previously approved these changes Oct 18, 2023
@thibault-martinez thibault-martinez dismissed stale reviews from Alex6323 and themself via 6c3daaa October 18, 2023 11:20
@thibault-martinez thibault-martinez merged commit a14a2a9 into 2.0 Oct 18, 2023
28 of 31 checks passed
@thibault-martinez thibault-martinez deleted the feat/transaction-capabilities branch October 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transaction capabilities bit mask
5 participants