Add mana calculations #1376
Merged
Add mana calculations #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2023 14:45
added 3 commits
October 2, 2023 15:00
sdk/src/client/api/mana.rs
Outdated
| }, | ||
| }; | ||
|
|
||
| impl Client { |
There was a problem hiding this comment.
I wouldn't put this in the client. All mana calculations should be in the types module, if possible in the mana module.
There was a problem hiding this comment.
The problem is the necessity of the epochs iter. We need the client to do that calculation anyway
Closed
Thoralf-M
reviewed
Oct 5, 2023
added 8 commits
October 5, 2023 08:27
kwek20
reviewed
Oct 11, 2023
| impl ProtocolParameters { | ||
| /// Calculates the potential mana that is generated by holding `amount` tokens from `slot_index_created` to | ||
| /// `slot_index_target` and applies the decay to the result | ||
| pub fn potential_mana(&self, amount: u64, slot_index_created: SlotIndex, slot_index_target: SlotIndex) -> u64 { |
Alex6323
reviewed
Oct 11, 2023
Alex6323
reviewed
Oct 11, 2023
Alex6323
reviewed
Oct 11, 2023
Alex6323
reviewed
Oct 11, 2023
Alex6323
reviewed
Oct 11, 2023
kwek20
previously approved these changes
Oct 11, 2023
Alex6323
previously approved these changes
Oct 12, 2023
Thoralf-M
approved these changes
Oct 12, 2023
Alex6323
approved these changes
Oct 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds mana calculations
Links to any relevant issues
Closes #1366