feat/Node: id() on wrapper #1369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2023 13:17
| * @param params The network protocol parameters. | ||
| * @returns The corresponding block ID. | ||
| */ | ||
| id(params: ProtocolParameters): BlockId { |
There was a problem hiding this comment.
Is this another scenario where we're going to be importing stuff we don't need if you just want the types?
There was a problem hiding this comment.
Seems to be so yes. :/
Thoralf-M
reviewed
Oct 2, 2023
| @@ -8,6 +8,8 @@ import { | |||
| TokenSchemeType, | |||
| Output, | |||
| RentStructure, | |||
There was a problem hiding this comment.
Can't comment there, but 'Block' is defined but never used
| @@ -15,6 +15,8 @@ import { | |||
| RentStructure, | |||
There was a problem hiding this comment.
Can't comment there, but 'Block' is defined but never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
the method
.id(protocolparams)was missing on the blockwrapper type, which we have in rust