Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: block types and wrapper #1346

Merged
merged 31 commits into from
Oct 4, 2023

Conversation

Alex6323
Copy link
Contributor

Description of change

Adds block types and wrapper.

Links to any relevant issues

#869
#873
#876

@Alex6323 Alex6323 marked this pull request as ready for review September 28, 2023 19:08
DaughterOfMars
DaughterOfMars previously approved these changes Sep 28, 2023
@Alex6323 Alex6323 force-pushed the python/block-changes branch from cd1f7ff to 5b160f8 Compare September 28, 2023 21:34
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

Thoralf-M
Thoralf-M previously approved these changes Oct 4, 2023
Thoralf-M
Thoralf-M previously approved these changes Oct 4, 2023
kwek20
kwek20 previously approved these changes Oct 4, 2023
@Alex6323 Alex6323 dismissed stale reviews from kwek20 and Thoralf-M via 09cfa59 October 4, 2023 12:15
from iota_sdk.utils import Utils

BlockUnion: TypeAlias = Union[BasicBlock, ValidationBlock]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now I guess but this should definitely not be here

@thibault-martinez thibault-martinez merged commit 9e8ef00 into iotaledger:2.0 Oct 4, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Block wrapper - python Add ValidationBlock - python Change Block into BasicBlock - python
5 participants