-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add work score trait and impls #1235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
reviewed
Sep 15, 2023
Thoralf-M
reviewed
Sep 18, 2023
Alex6323
force-pushed
the
feat/workscore
branch
from
September 20, 2023 14:36
7e76ae6
to
8ade41a
Compare
Alex6323
changed the title
Add workscore computation
feat(types): add work score computations
Oct 9, 2023
Alex6323
changed the title
feat(types): add work score computations
feat(types): add work score trait and impls
Oct 9, 2023
kwek20
reviewed
Oct 10, 2023
kwek20
reviewed
Oct 10, 2023
Co-authored-by: DaughterOfMars <[email protected]>
Alex6323
force-pushed
the
feat/workscore
branch
from
November 24, 2023 09:05
8c6743a
to
d002ed1
Compare
Thoralf-M
reviewed
Nov 24, 2023
Co-authored-by: Thibault Martinez <[email protected]>
Thoralf-M
previously approved these changes
Nov 24, 2023
Alex6323
force-pushed
the
feat/workscore
branch
2 times, most recently
from
November 27, 2023 08:33
c92d856
to
52d1091
Compare
Alex6323
force-pushed
the
feat/workscore
branch
from
November 27, 2023 08:33
52d1091
to
9f751e0
Compare
Thoralf-M
approved these changes
Nov 27, 2023
thibault-martinez
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces the
WorkScore
trait and impls it for all required types (BlockWrapper
et al).Links to any relevant issues
Closes #1018
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Not (yet)