Refactor rent cost traits #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Aug 29, 2023
Thoralf-M
reviewed
Aug 29, 2023
Thoralf-M
reviewed
Aug 30, 2023
Thoralf-M
reviewed
Aug 31, 2023
Thoralf-M
previously approved these changes
Aug 31, 2023
Thoralf-M
reviewed
Sep 1, 2023
Thoralf-M
reviewed
Sep 1, 2023
Thoralf-M
reviewed
Sep 4, 2023
Thoralf-M
previously approved these changes
Nov 13, 2023
thibault-martinez
previously approved these changes
Nov 14, 2023
thibault-martinez
approved these changes
Nov 14, 2023
kwek20
reviewed
Nov 14, 2023
Alex6323
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors rent cost so that it can be deeply derived and adds some helpful builder functionality. It also allows builder types to calculate rent cost so that you no longer need to convert back and forth between builder and output.
Related Issues
Closes #1124