static async constructor

bindings/nodejs/README.md

@@ -129,7 +129,7 @@ const walletOptions: WalletOptions = {
         },
     },
 };
-const wallet = new Wallet(walletOptions);
+const wallet = await Wallet.create(walletOptions);
 ```
 
 ## Examples

bindings/nodejs/examples/exchange/1-create-wallet.ts

@@ -61,7 +61,7 @@ async function run() {
             secretManager: strongholdSecretManager,
         };
 
-        const wallet = new Wallet(walletOptions);
+        const wallet = await Wallet.create(walletOptions);
 
         // Set syncOnlyMostBasicOutputs to true if not interested in outputs that are timelocked,
         // have a storage deposit return, expiration or are nft/account/foundry outputs.

bindings/nodejs/examples/exchange/3-check-balance.ts

@@ -18,7 +18,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
         const address = await wallet.address();

bindings/nodejs/examples/exchange/4-listen-events.ts

@@ -18,7 +18,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/exchange/5-send-amount.ts

@@ -23,7 +23,7 @@ async function run() {
                 );
             }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/account_output/create.ts

@@ -27,7 +27,7 @@ async function run() {
 
     try {
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/account_output/destroy.ts

@@ -23,7 +23,7 @@ async function run() {
 
     try {
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/account_wallet/request-funds.ts

@@ -23,7 +23,7 @@ async function run() {
         const faucetUrl = process.env.FAUCET_URL;
 
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/account_wallet/transaction.ts

@@ -29,7 +29,7 @@ async function run() {
             },
         };
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/accounts_and_addresses/check-balance.ts

@@ -16,7 +16,7 @@ async function run() {
         throw new Error('.env WALLET_DB_PATH is undefined, see .env.example');
     }
     try {
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/accounts_and_addresses/consolidate-outputs.ts

@@ -25,7 +25,7 @@ async function run() {
                 );
             }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/accounts_and_addresses/create-wallet.ts

@@ -66,7 +66,7 @@ async function run() {
             secretManager: strongholdSecretManager,
         };
 
-        const wallet = new Wallet(walletOptions);
+        const wallet = await Wallet.create(walletOptions);
 
         console.log(
             'Generated wallet with address: ' + (await wallet.address()),

bindings/nodejs/examples/how_tos/accounts_and_addresses/list-accounts.ts

@@ -16,7 +16,7 @@ async function run() {
         throw new Error('.env WALLET_DB_PATH is undefined, see .env.example');
     }
     try {
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/accounts_and_addresses/list-outputs.ts

@@ -16,7 +16,7 @@ async function run() {
         throw new Error('.env WALLET_DB_PATH is undefined, see .env.example');
     }
     try {
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/accounts_and_addresses/list-transactions.ts

@@ -16,7 +16,7 @@ async function run() {
         throw new Error('.env WALLET_DB_PATH is undefined, see .env.example');
     }
     try {
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
         await wallet.sync({ syncIncomingTransactions: true });

bindings/nodejs/examples/how_tos/advanced_transactions/advanced_transaction.ts

@@ -24,7 +24,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/advanced_transactions/claim_transaction.ts

@@ -17,7 +17,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/advanced_transactions/send_micro_transaction.ts

@@ -17,7 +17,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/nft_collection/00_mint_issuer_nft.ts

@@ -27,7 +27,7 @@ async function run() {
         }
 
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/nft_collection/01_mint_collection_nft.ts

@@ -25,7 +25,7 @@ async function run() {
         }
 
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/nfts/burn_nft.ts

@@ -20,7 +20,7 @@ async function run() {
         }
 
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/nfts/mint_nft.ts

@@ -39,7 +39,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/nfts/send_nft.ts

@@ -23,7 +23,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/simple_transaction/request-funds.ts

@@ -19,7 +19,7 @@ async function run() {
         const faucetUrl = process.env.FAUCET_URL;
 
         // Create the wallet
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/how_tos/simple_transaction/simple-transaction.ts

@@ -19,7 +19,7 @@ async function run() {
             );
         }
 
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: process.env.WALLET_DB_PATH,
         });
 

bindings/nodejs/examples/wallet/common.ts

@@ -22,7 +22,7 @@ async function getUnlockedWallet() {
     const walletOptions: WalletOptions = {
         storagePath: process.env.WALLET_DB_PATH,
     };
-    const wallet = new Wallet(walletOptions);
+    const wallet = await Wallet.create(walletOptions);
 
     return wallet;
 }

bindings/nodejs/examples/wallet/getting-started.ts

@@ -66,7 +66,7 @@ async function main() {
         secretManager: strongholdSecretManager,
     };
 
-    const wallet = new Wallet(walletOptions);
+    const wallet = await Wallet.create(walletOptions);
 
     console.log('Generated wallet with address: ' + (await wallet.address()));
 

bindings/nodejs/lib/wallet/wallet-method-handler.ts

@@ -22,11 +22,19 @@ import { SecretManager } from '../secret_manager';
 export class WalletMethodHandler {
     methodHandler: any;
 
+    /**
+     * @param methodHandler The Rust method handler created in `WalletMethodHandler.create()`.
+     */
+    constructor(methodHandler: any) {
+        this.methodHandler = methodHandler;
+    }
+
     /**
      * @param options The wallet options.
      */
-    constructor(options?: WalletOptions) {
-        this.methodHandler = createWallet(JSON.stringify(options));
+    static async create(options: WalletOptions): Promise<WalletMethodHandler> {
+        const methodHandler = await createWallet(JSON.stringify(options));
+        return new WalletMethodHandler(methodHandler);
     }
 
     /**

bindings/nodejs/lib/wallet/wallet.ts

@@ -62,10 +62,17 @@ export class Wallet {
     private methodHandler: WalletMethodHandler;
 
     /**
-     * @param options Wallet options.
+     * @param methodHandler The Rust method handler created in `WalletMethodHandler.create()`.
      */
-    constructor(options: WalletOptions) {
-        this.methodHandler = new WalletMethodHandler(options);
+    constructor(methodHandler: WalletMethodHandler) {
+        this.methodHandler = methodHandler;
+    }
+
+    /**
+     * @param options The wallet options.
+     */
+    static async create(options: WalletOptions): Promise<Wallet> {
+        return new Wallet(await WalletMethodHandler.create(options));
     }
 
     /**

bindings/nodejs/src/wallet.rs

@@ -17,10 +17,9 @@ use crate::{client::ClientMethodHandler, secret_manager::SecretManagerMethodHand
 pub type WalletMethodHandler = Arc<RwLock<Option<Wallet>>>;
 
 #[napi(js_name = "createWallet")]
-pub fn create_wallet(options: String) -> Result<External<WalletMethodHandler>> {
+pub async fn create_wallet(options: String) -> Result<External<WalletMethodHandler>> {
     let wallet_options = serde_json::from_str::<WalletOptions>(&options).map_err(NodejsError::from)?;
-    let runtime = tokio::runtime::Runtime::new().map_err(NodejsError::from)?;
-    let wallet = runtime.block_on(wallet_options.build()).map_err(NodejsError::from)?;
+    let wallet = wallet_options.build().await.map_err(NodejsError::from)?;
 
     Ok(External::new(Arc::new(RwLock::new(Some(wallet)))))
 }

bindings/nodejs/tests/wallet/wallet.spec.ts

@@ -45,7 +45,7 @@ describe('Wallet', () => {
         };
 
 
-        const wallet = new Wallet(walletOptions);
+        const wallet = await Wallet.create(walletOptions);
 
         await wallet.destroy()
         removeDir(storagePath)
@@ -90,15 +90,15 @@ describe('Wallet', () => {
         };
 
 
-        const wallet = new Wallet(walletOptions);
+        const wallet = await Wallet.create(walletOptions);
 
         const client = await wallet.getClient();
         const hrp = await client.getBech32Hrp();
         expect(hrp).toEqual("smr");
 
         await wallet.destroy();
 
-        const recreatedWallet = new Wallet({ storagePath: './test-recreate-wallet' });
+        const recreatedWallet = await Wallet.create({ storagePath: './test-recreate-wallet' });
 
         await recreatedWallet.destroy()
         removeDir(storagePath)

bindings/wasm/README.md

@@ -185,7 +185,7 @@ const { Wallet, CoinType } = require('@iota/sdk-wasm/node');
 
 async function run() {
     try {
-        const wallet = new Wallet({
+        const wallet = await Wallet.create({
             storagePath: './my-database',
             coinType: CoinType.Shimmer,
             clientOptions: {
@@ -214,7 +214,7 @@ run().then(() => process.exit());
 import init, {Wallet, CoinType} from "@iota/sdk-wasm/web";
 
 init().then(async () => {
-    const wallet = new Wallet({
+    const wallet = await Wallet.create({
         storagePath: './my-database',
         coinType: CoinType.Shimmer,
         clientOptions: {

bindings/wasm/examples/node.js

@@ -29,7 +29,7 @@ async function run() {
         bech32Hrp: 'tst',
     });
 
-    const wallet = new Wallet({
+    const wallet = await Wallet.create({
         address: walletAddress[0],
         storagePath: './alice-database',
         bipPath: {

bindings/wasm/src/wallet.rs

@@ -28,13 +28,10 @@ pub struct WalletMethodHandler {
 /// Creates a method handler with the given options.
 #[wasm_bindgen(js_name = createWallet)]
 #[allow(non_snake_case)]
-pub fn create_wallet(options: String) -> Result<WalletMethodHandler, JsValue> {
+pub async fn create_wallet(options: String) -> Result<WalletMethodHandler, JsValue> {
     let wallet_options = serde_json::from_str::<WalletOptions>(&options).map_err(|e| e.to_string())?;
 
-    let wallet_method_handler = tokio::runtime::Builder::new_current_thread()
-        .build()
-        .map_err(|err| err.to_string())?
-        .block_on(async move { wallet_options.build().await.map_err(|e| e.to_string()) })?;
+    let wallet_method_handler = wallet_options.build().await.map_err(|e| e.to_string())?;
 
     Ok(WalletMethodHandler {
         wallet: Arc::new(Mutex::new(Some(wallet_method_handler))),

bindings/wasm/test/wallet.spec.ts

@@ -21,7 +21,7 @@ async function run() {
         bech32Hrp: 'tst',
     });
 
-    const wallet = new Wallet({
+    const wallet = await Wallet.create({
         address: walletAddress[0],
         bipPath: {
             coinType: CoinType.IOTA,

sdk/src/wallet/core/builder.rs

@@ -270,9 +270,6 @@ where
         // If the wallet builder is not set, it means the user provided it and we need to update the addresses.
         // In the other case it was loaded from the database and addresses are up to date.
         if provided_client_options {
-            // Can't call it in wasm, because it will panic with `condvar wait not supported`. Updating the bech32 hrp
-            // is still possible in wasm when setting the client options on the wallet.
-            #[cfg(not(target_family = "wasm"))]
             wallet.update_bech32_hrp().await?;
         }