Internally compute transaction ID

iotaledger · Nov 5, 2023 · 3f67968 · 3f67968
1 parent 3ecbc84
commit 3f67968
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/sdk/src/client/api/block_builder/transaction.rs b/sdk/src/client/api/block_builder/transaction.rs
@@ -30,15 +30,13 @@ pub fn verify_semantic(
     input_signing_data: &[InputSigningData],
     transaction_payload: &SignedTransactionPayload,
 ) -> crate::client::Result<Option<TransactionFailureReason>> {
-    let transaction_id = transaction_payload.transaction().id();
     let inputs = input_signing_data
         .iter()
         .map(|input| (input.output_id(), &input.output))
         .collect::<Vec<(&OutputId, &Output)>>();
 
     let context = SemanticValidationContext::new(
         transaction_payload.transaction(),
-        &transaction_id,
         &inputs,
         Some(transaction_payload.unlocks()),
     );

diff --git a/sdk/src/types/block/semantic.rs b/sdk/src/types/block/semantic.rs
@@ -13,7 +13,7 @@ use crate::types::block::{
         AnchorOutput, ChainId, FoundryId, NativeTokens, Output, OutputId, StateTransitionError, TokenId,
         UnlockCondition,
     },
-    payload::signed_transaction::{Transaction, TransactionCapabilityFlag, TransactionId, TransactionSigningHash},
+    payload::signed_transaction::{Transaction, TransactionCapabilityFlag, TransactionSigningHash},
     unlock::Unlocks,
     Error,
 };
@@ -212,10 +212,11 @@ impl<'a> SemanticValidationContext<'a> {
     ///
     pub fn new(
         transaction: &'a Transaction,
-        transaction_id: &TransactionId,
         inputs: &'a [(&'a OutputId, &'a Output)],
         unlocks: Option<&'a Unlocks>,
     ) -> Self {
+        let transaction_id = transaction.id();
+
         Self {
             transaction,
             transaction_signing_hash: transaction.signing_hash(),
@@ -242,7 +243,7 @@ impl<'a> SemanticValidationContext<'a> {
                 .filter_map(|(index, output)| {
                     output.chain_id().map(|chain_id| {
                         (
-                            chain_id.or_from_output_id(&OutputId::new(*transaction_id, index as u16).unwrap()),
+                            chain_id.or_from_output_id(&OutputId::new(transaction_id, index as u16).unwrap()),
                             output,
                         )
                     })