Feat: Introduce alias for StateReferences in mempool and cleanup types #1750
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (3)
pkg/protocol/engine/mempool/tests/vm.go|17 col 33| unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/engine/mempool/tests/vm.go|21 col 22| unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/engine/mempool/tests/vm.go|14 col 9| type assertion must be checked (forcetypeassert)
Filtered Findings (0)
Annotations
Check failure on line 17 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L17
unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:17:33: unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
func (V *VM) ValidateSignatures(signedTransaction mempool.SignedTransaction, resolvedInputs []mempool.State) (executionContext context.Context, err error) {
^
Check failure on line 21 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L21
unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:21:22: unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
func (V *VM) Execute(executionContext context.Context, transaction mempool.Transaction) (outputs []mempool.State, err error) {
^
Check failure on line 14 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L14
type assertion must be checked (forcetypeassert)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:14:9: type assertion must be checked (forcetypeassert)
return transaction.(*Transaction).Inputs()
^