Feat: Introduce alias for StateReferences in mempool and cleanup types #1772
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (3)
pkg/protocol/engine/mempool/tests/vm.go|18 col 33| unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/engine/mempool/tests/vm.go|22 col 33| unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/engine/mempool/tests/vm.go|15 col 9| type assertion must be checked (forcetypeassert)
Filtered Findings (0)
Annotations
Check failure on line 18 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L18
unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:18:33: unused-parameter: parameter 'signedTransaction' seems to be unused, consider removing or renaming it as _ (revive)
func (V *VM) ValidateSignatures(signedTransaction mempool.SignedTransaction, resolvedInputs []mempool.State) (executionContext context.Context, err error) {
^
Check failure on line 22 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L22
unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:22:33: unused-parameter: parameter 'executionContext' seems to be unused, consider removing or renaming it as _ (revive)
func (V *VM) ExecuteTransaction(executionContext context.Context, transaction mempool.Transaction) (outputs []mempool.State, err error) {
^
Check failure on line 15 in pkg/protocol/engine/mempool/tests/vm.go
github-actions / golangci
[golangci] pkg/protocol/engine/mempool/tests/vm.go#L15
type assertion must be checked (forcetypeassert)
Raw output
pkg/protocol/engine/mempool/tests/vm.go:15:9: type assertion must be checked (forcetypeassert)
return transaction.(*Transaction).Inputs()
^