Skip to content

Feat: Reactive protocol rework #1558

Feat: Reactive protocol rework

Feat: Reactive protocol rework #1558

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / golangci failed Sep 12, 2023 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (2)

pkg/protocol/gossip.go|202 col 42| unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/gossip.go|206 col 41| unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)

Filtered Findings (0)

Annotations

Check failure on line 202 in pkg/protocol/gossip.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/protocol/gossip.go#L202

unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/gossip.go:202:42: unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)
func (r *Gossip) ProcessWarpSyncResponse(commitmentID iotago.CommitmentID, blockIDs iotago.BlockIDs, proof *merklehasher.Proof[iotago.Identifier], src peer.ID) {
                                         ^

Check failure on line 206 in pkg/protocol/gossip.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/protocol/gossip.go#L206

unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/gossip.go:206:41: unused-parameter: parameter 'commitmentID' seems to be unused, consider removing or renaming it as _ (revive)
func (r *Gossip) ProcessWarpSyncRequest(commitmentID iotago.CommitmentID, src peer.ID) {
                                        ^