Fix scheduler bug and add panics #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
reviewed
Apr 29, 2024
pkg/protocol/engine/congestioncontrol/scheduler/drr/issuerqueue.go
Outdated
Show resolved
Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/issuerqueue.go
Outdated
Show resolved
Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/issuerqueue.go
Outdated
Show resolved
Hide resolved
muXxer
approved these changes
Apr 29, 2024
muXxer
force-pushed
the
fix/scheduler-bug
branch
from
36ad29c to
809012e
Compare
This was
linked to
issues
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #936
When issuer queues were removed, there was a possibility that the overall buffer size would not decrease by the correct amount do to use of PopFront() in the removeIssuer() function, where the issuer queue size was decreased, but not the overall buffer size. This is now fixed by not using PopFront in this place.
Also some panics have been added in places where we check for conditions that should never occur. Rather than return nil or some empty value, we should panic in such cases to detect the problem early.