Unify wallet: Part 2 #889
Merged
Unify wallet: Part 2 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daria305
reviewed
Mar 28, 2024
PhilippGackstatter
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Looks good to me. Minor comments.
There are a lot of occurences of creating a basic block where the alias is set to "". I think it would be good to set aliases there in case this test ever fails and we look at an error message containing that alias, then a string like "_tagged_data_block" is easier to find and debug than "". Just a thought. If you feel this is unnecessary, feel free to skip.
muXxer
reviewed
Apr 22, 2024
Co-authored-by: Philipp Gackstatter <[email protected]>
Co-authored-by: Philipp Gackstatter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #837
This PR removes the DockerWallet and replaces it with the mock Wallet used in the testsuite, but with a nodeclient for the docker network and using a real clock instead of the testsuite time.
closes #789