Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Orphanage #834

Merged
merged 25 commits into from
Apr 17, 2024
Merged

Fix: Orphanage #834

merged 25 commits into from
Apr 17, 2024

Conversation

hmoog
Copy link
Contributor

@hmoog hmoog commented Mar 13, 2024

No description provided.

@hmoog hmoog changed the base branch from develop to feat/engine-logging March 13, 2024 15:59
Base automatically changed from feat/engine-logging to develop March 14, 2024 16:20
piotrm50
piotrm50 reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the fruit spams in the Docker network as well.

pkg/protocol/engine/blocks/block.go Outdated Show resolved Hide resolved
pkg/protocol/engine/booker/inmemorybooker/booker.go Outdated Show resolved Hide resolved
pkg/tests/booker_test.go Outdated Show resolved Hide resolved
@piotrm50 piotrm50 linked an issue Apr 2, 2024 that may be closed by this pull request
Revisit transaction orphanage #784
Closed
@hmoog hmoog marked this pull request as ready for review April 15, 2024 20:12
@hmoog hmoog enabled auto-merge April 17, 2024 10:46
@hmoog hmoog merged commit 3822ac2 into develop Apr 17, 2024
4 checks passed
@hmoog hmoog deleted the fix/orphanage2 branch April 17, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis left review comments

@piotrm50 piotrm50 piotrm50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit transaction orphanage
3 participants
@hmoog @piotrm50 @jonastheis