Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Fix trigger of StateDiffApplied event before commitment is stored #536

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix trigger of StateDiffApplied event before commitment is stored #536

merged 1 commit into from
Nov 20, 2023
+20 −19

Conversation

muXxer
Copy link
Collaborator

@muXxer muXxer commented Nov 20, 2023 •
edited
Loading

This PR removes the Ledger.StateDiffApplied event, and instead publishes the info about created and consumed outputs via Notarization.SlotCommited event.

This way the inx ListenToLedgerUpdates propagates the info to the clients after the commitment was successfully stored in the node.

alexsporn
alexsporn approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@alexsporn alexsporn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't completely like this being part of SlotCommitted, but don't see another solution right now.

@muXxer muXxer merged commit 2dc7db9 into develop Nov 20, 2023
4 checks passed
@muXxer muXxer deleted the fix/ledger-updates-before-commitment branch November 20, 2023 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muXxer @alexsporn