Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dPoS #506

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Enable dPoS #506

merged 14 commits into from
Nov 15, 2023

Conversation

jonastheis
Copy link
Contributor

@jonastheis jonastheis commented Nov 8, 2023

This PR enables the previously implemented top stakers committee selection. It adapts to the changes from iotaledger/iota.go#598 and also allows for committees that are smaller than TargetCommitteeSize in case there's fewer candidates available.

It adds end-to-end test for following scenarios:

  • committee rotation with candidacy announcements at different times (slots) within the epoch
  • committee reuse due to no candidates announced but slot finalized
  • committee reuse due to no slot finalization at EpochNearingThreshold
  • committee rotation to a smaller committee than TargetCommitteeSize

Fixes #494 and #495

@jonastheis jonastheis linked an issue Nov 8, 2023 that may be closed by this pull request
- committee rotation with candidacy announcements at different times
- committee reuse due to no candidates announced but slot finalized
- committee reuse due to no slot finalization at epochNearingThreshold
- committee rotation to a smaller committee than TargetCommitteeSize
Copy link
Collaborator

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good :) Just need to remove some printlns and maybe run it in a docker network for a while with shorter epochs.

@jonastheis jonastheis marked this pull request as ready for review November 14, 2023 03:29
…ven epoch for the next epoch, adjust when we rotate the committee and tests accordingly
Copy link
Collaborator

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonastheis jonastheis merged commit 3ab0b0a into develop Nov 15, 2023
4 checks passed
@jonastheis jonastheis deleted the feat/enable-dpos branch November 15, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable top-stakers dPoS Finalization threshold on _seated_ committee members
2 participants