Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet-centric account testing #448

Merged
merged 28 commits into from
Oct 29, 2023
Merged

Conversation

cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Oct 19, 2023

The aim of these changes is to make the testing flow in the accounts tests be centred around wallets (like firefly wallets). The wallet models the following:

  • hierarchical deterministic key management
  • signing transactions
  • signing blocks
  • keeping track of owned unspent outputs

Wallets are used throughout the tests package for creation of transactions and issuance of basic blocks.

Nodes have a blockissuer module of their own for validation, so nodes issue validation blocks.

closes #292

@cyberphysic4l cyberphysic4l marked this pull request as draft October 19, 2023 16:02
@cyberphysic4l cyberphysic4l marked this pull request as ready for review October 25, 2023 08:06
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Nice that you factored the keymanager out of the wallet and made the transactions separate from the accounts test. That is much nicer to read now!

pkg/tests/accounts_test.go Outdated Show resolved Hide resolved
pkg/testsuite/mock/wallet.go Outdated Show resolved Hide resolved
pkg/testsuite/mock/wallet_transactions.go Outdated Show resolved Hide resolved
pkg/testsuite/mock/wallet_transactions.go Outdated Show resolved Hide resolved
pkg/tests/accounts_test.go Outdated Show resolved Hide resolved
pkg/tests/accounts_test.go Outdated Show resolved Hide resolved
pkg/tests/accounts_test.go Outdated Show resolved Hide resolved
@cyberphysic4l cyberphysic4l merged commit e226f5f into develop Oct 29, 2023
5 checks passed
@cyberphysic4l cyberphysic4l deleted the feat/wallet-centric-testing branch October 29, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix accounts test changing expiry slot
2 participants