Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validator component to INX plugin #443

Merged
merged 37 commits into from
Oct 31, 2023
Merged

Move validator component to INX plugin #443

merged 37 commits into from
Oct 31, 2023

Conversation

piotrm50
Copy link
Collaborator

No description provided.

@piotrm50 piotrm50 self-assigned this Oct 18, 2023
@piotrm50 piotrm50 mentioned this pull request Oct 18, 2023
Merged
muXxer
muXxer requested changes Oct 24, 2023
View reviewed changes
tools/docker-network/run.sh Outdated Show resolved Hide resolved
tools/docker-network/docker-compose.yml Outdated Show resolved Hide resolved
@piotrm50 piotrm50 marked this pull request as ready for review October 27, 2023 07:16
@piotrm50 piotrm50 requested a review from muXxer October 27, 2023 10:10
muXxer
muXxer requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes in the ansible setup.
Can you do these changes there as well?

muXxer
muXxer reviewed Oct 27, 2023
View reviewed changes
tools/docker-network/docker-compose.yml Show resolved Hide resolved
tools/docker-network/docker-compose.yml Show resolved Hide resolved
tools/docker-network/docker-compose.yml Show resolved Hide resolved
tools/docker-network/docker-compose.yml Outdated Show resolved Hide resolved
tools/docker-network/docker-compose.yml Outdated Show resolved Hide resolved
tools/docker-network/docker-compose.yml Outdated Show resolved Hide resolved
@piotrm50 piotrm50 requested a review from muXxer October 30, 2023 15:00
muXxer
muXxer reviewed Oct 30, 2023
View reviewed changes
deploy/ansible/roles/iota-core-node/templates/docker-compose-iota-core.yml.j2 Outdated
restart: unless-stopped
depends_on:
iota-core:
condition: service_healthy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that some kind of race condition? Can the nodes even be healthy if there is no validator in the network yet?

@karimodm karimodm requested a review from muXxer October 31, 2023 11:17
@piotrm50 piotrm50 temporarily deployed to feature October 31, 2023 15:25 — with GitHub Actions Inactive
@piotrm50 piotrm50 temporarily deployed to feature October 31, 2023 15:40 — with GitHub Actions Inactive
@piotrm50 piotrm50 merged commit 16ecf8c into develop Oct 31, 2023
7 checks passed
@piotrm50 piotrm50 deleted the feat/move-validator-plugin-to-inx branch October 31, 2023 16:45
@karimodm karimodm linked an issue Nov 1, 2023 that may be closed by this pull request
Validator INX plugin #424
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muXxer muXxer muXxer approved these changes

@karimodm karimodm karimodm approved these changes

Assignees

@piotrm50 piotrm50

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator INX plugin
3 participants
@piotrm50 @karimodm @muXxer