Feat: Reset logic for engine to roll-back in memory. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoog
changed the title
hmoog
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
karimodm
approved these changes
Nov 10, 2023
piotrm50
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a mechanism to Reset an engine to its clean state after the last commitment, without having to restart the entire engine.
This PR only addresses the parts of the code that are relevant for the commitments as other things will eventually get evicted anyway, but we should maybe revisit the TODOs that I left in the code in a separate PR, once this is no longer a blocker.