New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement candidate registration and TopStakers seat manager. #408

Merged

piotrm50 merged 33 commits into develop from feat/top-stakers-seatmanager

Oct 25, 2023

Collaborator

piotrm50 commented Oct 9, 2023

This PR adds support for top staker committee selection as well as registering candidates for next epoch committee selection.

Candidates are registered whenever they issue a single block before Epoch Nearing Threshold in the previous epoch.


          Implement TopStakers seat manager WIP

karimodm linked an issue

that may be closed by this pull request

Candidates for committee selection #322

Closed

piotrm50 added 3 commits

October 9, 2023 14:21


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

350c3e9

…eatmanager


          Fix storing committee in storage

78016bf


          Implement and fix unit tests

0f7b8ff

piotrm50 linked an issue

that may be closed by this pull request

Top stakers committee selection #321

Closed

piotrm50 added 11 commits

October 10, 2023 11:10


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

8cd26b9

…eatmanager


          Implement unit test and fix some issues

986f7a9


          Start implementing end-to-end test for top-staker committee rotation

75118fd


          Fix first part of the committee rotation test

f7b0337


          Merge branch 'develop' into feat/top-stakers-seatmanager

66d43f7


          Fix mockseatmanager

13ecf5c


          Fix unit tests.

3dd4bfe


          Add candidacy announcement payload and extend committee rotation unit…

9a73547

… test.


          Update iota.go version

65f13ea


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

34f71e5

…eatmanager


          Fix unit tests

5667a5a

piotrm50 marked this pull request as ready for review

October 13, 2023 12:07

piotrm50 added 4 commits

October 19, 2023 13:49


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

f0245f3

…eatmanager


          Post merge fixes

6e4d233


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

db03c59

…eatmanager


          Post merge fixes

1a934ed

alexsporn reviewed

View reviewed changes

pkg/protocol/commitment_verifier.go Outdated Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/seatmanager/topstakers/topstakers.go Outdated Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/seatmanager/topstakers/topstakers.go Outdated Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/seatmanager/topstakers/topstakers.go Outdated Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/seatmanager/topstakers/topstakers.go Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/seatmanager/topstakers/topstakers.go Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/protocol/sybilprotection/sybilprotectionv1/sybilprotection.go Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/storage/prunable/prunable.go Outdated Show resolved Hide resolved

alexsporn reviewed

View reviewed changes

pkg/storage/prunable/prunable_slot.go Outdated Show resolved Hide resolved

alexsporn requested changes

View reviewed changes

Member

alexsporn left a comment

This kind of introduces a lot of new TODOs

piotrm50 added 8 commits

October 23, 2023 08:32


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

245a99b

…eatmanager


          Extract activity tracker from POA and TopStakers seat managers.

4d65933


          Apply review suggestions.

59a3231


          Add more tie-breaking and change data provided to seat manager to rot…

161c675

…ate committee.


          Check if commmittee in slot exists instead of using Return1 and ign…

3cd65cb

…oring exists return value.


          Do not ignore return value that indicates if committee exists.

be1d5cd


          Re-use the previous committee if there are not enough candidates.

e5ec71d


          Handle edge-cases when committee in block slot does not exist

d24b2ab

piotrm50 requested a review from alexsporn

October 24, 2023 14:11

alexsporn approved these changes

View reviewed changes

piotrm50 added 5 commits

October 24, 2023 22:35


          Fix linter errors.

bcbf538


          Fix unit test

82d7c71


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

05a416d

…eatmanager


          Fix wrong property name

09c05fd


          Improve error handling.

622b004

alexsporn approved these changes

View reviewed changes


          Merge remote-tracking branch 'origin/develop' into feat/top-stakers-s…

4591f73

…eatmanager

piotrm50 enabled auto-merge

October 25, 2023 10:11

piotrm50 merged commit 0329a5e into develop

4 checks passed

piotrm50 deleted the feat/top-stakers-seatmanager branch

October 25, 2023 10:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet