Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BIC to throughput and add 1 to quantum #394

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Conversation

cyberphysic4l
Copy link
Contributor

This PR makes two simple but important changes to throughput in the scheduler.

  1. We include the Block Issuance Credits (BIC) in the throughput for a block issuer in the DRR scheduler. Previously, it was only based on the stored and potential Mana on the account output of the issuer, but now we also include the BIC in this value. BIC is locked to the account to an even greater extent than the stored and potential Mana so it makes sense to include it for the throughput allowance. For any user that may wish to pre-allot their Mana, this means they do not need to choose between allotting the Mana and using it for their throughput, if they allot it they get it towards their throughput as well now.
  2. We now always have a quantum of at least one for a block issuer, even if they have zero Mana. The storage deposit on the account output is sufficient spam protection, so this does not amount to giving free throughput. Although the issuers are "zero-mana" issuers, they are not free to create. The schedule will still operate in the same fashion in times of congestion, prioritising issuers with higher Mana.

Copy link
Collaborator

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MinMana should be removed from ProtocolParameters since we always assume that everyone has at least MinMana.

@cyberphysic4l cyberphysic4l requested a review from piotrm50 October 3, 2023 15:55
@hmoog hmoog enabled auto-merge October 3, 2023 18:31
@hmoog hmoog merged commit 7f46ee8 into develop Oct 3, 2023
5 checks passed
@hmoog hmoog deleted the feat/throughput-mana branch October 3, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants