Update performance tracker and rewards #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the highest supported version
# Conflicts: # pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go # pkg/protocol/sybilprotection/sybilprotectionv1/performance/testsuite_test.go # pkg/storage/prunable/prunable.go
# Conflicts: # pkg/protocol/sybilprotection/sybilprotectionv1/performance/testsuite_test.go
# Conflicts: # pkg/protocol/engine/upgrade/signalingupgradeorchestrator/orchestrator.go # pkg/protocol/engine/upgrade/signalingupgradeorchestrator/snapshot.go # pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go # pkg/protocol/sybilprotection/sybilprotectionv1/performance/rewards.go # pkg/protocol/sybilprotection/sybilprotectionv1/performance/snapshot.go # pkg/protocol/sybilprotection/sybilprotectionv1/performance/testsuite_test.go # pkg/storage/prunable/performancefactors.go # pkg/storage/prunable/prunable.go # tools/genesis-snapshot/presets/presets.go
jonastheis
suggested changes
Sep 7, 2023
pkg/protocol/sybilprotection/sybilprotectionv1/performance/snapshot.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/snapshot_test.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/testsuite_test.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go
Outdated
Show resolved
Hide resolved
pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go
Outdated
Show resolved
Hide resolved
| decreaseAccuracy(increasedAccuracyComplement(poolStats.ProfitMargin, profitMarginExponent)*uint64(rewardsForAccountInEpoch.PoolRewards), profitMarginExponent)* | ||
| uint64(stakeAmount)/ | ||
| uint64(rewardsForAccountInEpoch.PoolStake) | ||
| // all rewards go to delegators, as the fixed cost was too high |
There was a problem hiding this comment.
I don't understand this comment. isn't the fixed cost for the validator meaning that no rewards go to the delegators?
There was a problem hiding this comment.
this is a form of punishment for the validator that add an unreasonably high fixed cost. if fixed cost>pool reward, we "slash" the validator reward
There was a problem hiding this comment.
however, the way it is now, the validator will get zero for the whole time period, not for the specific epochs where this happened. It's not an urgent matter, but I feel like this can be a problem in the future with the random committees
There was a problem hiding this comment.
since the validator won't know in advance the order of magnitude of his reward for every single epoch, I think this could become a punishment for unlucky people in the future :/
pkg/protocol/sybilprotection/sybilprotectionv1/performance/rewards.go
Outdated
Show resolved
Hide resolved
oliviasaa
reviewed
Sep 11, 2023
pkg/protocol/sybilprotection/sybilprotectionv1/performance/testsuite_test.go
Outdated
Show resolved
Hide resolved
jonastheis
approved these changes
Sep 20, 2023
# Conflicts: # go.mod # go.sum # tools/evil-spammer/go.sum # tools/gendoc/go.mod # tools/gendoc/go.sum # tools/genesis-snapshot/go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258 #155
model.ValidatorPerformanceValidatorPerformance