Improvements

tools/code-analysis/detect_modified_after_captured_variables.go

@@ -43,8 +43,10 @@ func main() {
 			for _, expr := range t.Lhs {
 				if ident, ok := expr.(*ast.Ident); ok {
 					if pos, captured := capturedVars[ident.Name]; captured {
-						pos := fset.Position(pos)
-						fmt.Printf("%s:%d: variable '%s' captured and modified outside closure\n", pos.Filename, pos.Line, ident.Name)
+						capturedPos := fset.Position(pos)
+						modifiedPos := fset.Position(ident.Pos())
+						fmt.Printf("%s:%d: variable '%s' captured by closure and modified at %s:%d\n",
+							capturedPos.Filename, capturedPos.Line, ident.Name, modifiedPos.Filename, modifiedPos.Line)
 					}
 				}
 			}
@@ -74,6 +76,10 @@ func main() {
 					return true
 				}
 
+				if ident.Name == "_" { // skip underscore variables
+					return true
+				}
+
 				if ident.Obj == nil || ident.Obj.Kind != ast.Var {
 					return true
 				}

tools/code-analysis/examples/redeclared_in_different_scope.go

@@ -0,0 +1,14 @@
+package main
+
+import "fmt"
+
+func redaclered() {
+	x := 42
+
+	// Outer closure
+	func() {
+		fmt.Println(x)
+	}()
+
+	x = 2
+}