GolangCIlint

Remove dashboard component #3375

Sign in to view logs

Triggered via pull request April 17, 2024 13:04

muXxer

synchronize #675

remove/dashboard-component

Status Failure

Total duration 2m 14s

Artifacts –

golangci-lint.yml

on: pull_request

Annotations

3 errors and 3 warnings

GolangCI-Lint: pkg/network/p2p/neighbor.go#L170

type assertion must be checked (forcetypeassert)

GolangCI-Lint: tools/genesis-snapshot/presets/presets_yaml.go#L39

yaml(camel): got 'bech32HRP' want 'bech32Hrp' (tagliatelle)

GolangCI-Lint

issues found

GolangCI-Lint

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

GolangCI-Lint: pkg/network/p2p/metrics.go#L8

exported: type name will be used as p2p.P2PMetrics by other packages, and that stutters; consider calling this Metrics (revive)

GolangCI-Lint: components/dashboard_metrics/component.go#L70

unused-parameter: parameter 'block' seems to be unused, consider removing or renaming it as _ (revive)