Skip to content

Fix some bugs when integrating cached reset branch #582

Fix some bugs when integrating cached reset branch

Fix some bugs when integrating cached reset branch #582

Triggered via pull request October 28, 2023 00:09
@hmooghmoog
synchronize #474
fix/reset
Status Success
Total duration 3m 34s
Artifacts

build_tools.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

12 errors
[golangci] pkg/storage/storage_prunable.go#L43: pkg/storage/storage_prunable.go#L43
Error return value of `s.Rollback` is not checked (errcheck)
[golangci] pkg/storage/prunable/prunable.go#L153: pkg/storage/prunable/prunable.go#L153
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/storage/prunable/prunable.go#L159: pkg/storage/prunable/prunable.go#L159
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/storage/prunable/prunable.go#L165: pkg/storage/prunable/prunable.go#L165
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/storage/prunable/prunable.go#L171: pkg/storage/prunable/prunable.go#L171
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/protocol/network_clock.go#L25: pkg/protocol/network_clock.go#L25
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
[golangci] pkg/protocol/chain.go#L234: pkg/protocol/chain.go#L234
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/protocol/chain_manager.go#L267: pkg/protocol/chain_manager.go#L267
superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
[golangci] pkg/protocol/chain.go#L229: pkg/protocol/chain.go#L229
func `(*Chain).earliestUncommittedSlot` is unused (unused)