Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition for finalized blocks #1389

Closed

Conversation

Alex6323
Copy link
Collaborator

@Alex6323 Alex6323 commented May 13, 2024

The problem is that we currently call get_accepted_blocks too early when blocks were "just" confirmed in the node software. I confirmed this by waiting for 2s before making that call, and then Chronicle was able to fetch them as finalized.

Instead of an arbitrary waiting time, this PR relaxes the block-state requirement for Chronicle to "confirmed or finalized".

@Alex6323
Copy link
Collaborator Author

we found a good solution with #1395

@Alex6323 Alex6323 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant