fix: race condition for finalized blocks #1389
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we currently call
get_accepted_blocks
too early when blocks were "just" confirmed in the node software. I confirmed this by waiting for 2s before making that call, and then Chronicle was able to fetch them as finalized.Instead of an arbitrary waiting time, this PR relaxes the block-state requirement for Chronicle to "confirmed or finalized".